This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Revert "Fix memory leak for size-zero ndarray" #14477
Merged
+12
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3ab1dec.
|
@anirudh2290 @apeforest please help merge once CI passes. |
anirudh2290
approved these changes
Mar 20, 2019
apeforest
approved these changes
Mar 20, 2019
One of the failures was from the code path (Storage::Get()->Free(shandle)) after I removed the size > 0 check. |
ZhennanQin
pushed a commit
to ZhennanQin/incubator-mxnet
that referenced
this pull request
Apr 3, 2019
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #14365
Removing size > 0 check in some paths caused flakiness in tests. I see two tests are failing intermittently: test_operator_gpu.test_ndarray_elementwisesum in Python2 GPU and test_sparse_parameter in Perl GPU.
Let's revert this change to make CI more stable while we are investigating further.